Skip to content

docs: Simplify React Native sidebar navigation #5800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2024
Merged

docs: Simplify React Native sidebar navigation #5800

merged 1 commit into from
Dec 19, 2024

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Dec 19, 2024 •
edited by pr-codex bot
Loading

Problem solved

Fixes TOOL-2788

PR-Codex overview

This PR refactors the sidebar in the sidebar.tsx file by removing several sections related to documentation links and hooks, simplifying the structure, and updating some names and links for better clarity.

Detailed summary

  • Removed sections for "Core", "Wallets", "Social API", "Pay", "Blockchain API".
  • Added a new entry for "Differences from React".
  • Updated "TypeScript reference" to "TypeScript docs".
  • Changed "React reference" to "React docs".
  • Renamed "Full Reference" to "API Reference".

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 593ed01

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 0:15am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Dec 19, 2024 0:15am
thirdweb-www ⬜️ Skipped (Inspect) Dec 19, 2024 0:15am
wallet-ui ⬜️ Skipped (Inspect) Dec 19, 2024 0:15am

@vercel vercel bot temporarily deployed to Preview – wallet-ui December 19, 2024 00:05 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 19, 2024 00:05 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 19, 2024 00:05 Inactive
@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Dec 19, 2024
@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Dec 19, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@linear
Copy link

linear bot commented Dec 19, 2024

TOOL-2788 [Portal] Organize 'React Native' page

@joaquim-verges joaquim-verges marked this pull request as ready for review December 19, 2024 00:06
@joaquim-verges joaquim-verges requested review from a team and jakubkrehel as code owners December 19, 2024 00:06
@joaquim-verges joaquim-verges force-pushed the docs_Simplify_React_Native_sidebar_navigation branch from 61efae3 to 593ed01 Compare December 19, 2024 00:07
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 19, 2024 00:07 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 19, 2024 00:07 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 19, 2024 00:07 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.02 KB (0%) 901 ms (0%) 4 s (+55.43% 🔺) 4.9 s
thirdweb (cjs) 110.76 KB (0%) 2.3 s (0%) 6.6 s (-1.46% 🔽) 8.8 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 284 ms (+41.2% 🔺) 396 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 123 ms (+151.23% 🔺) 133 ms
thirdweb/react (minimal + tree-shaking) 19.1 KB (0%) 383 ms (0%) 681 ms (-17.56% 🔽) 1.1 s

@codecov
Copy link

codecov bot commented Dec 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.01%. Comparing base (a2a61df) to head (593ed01).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5800   +/-   ##
=======================================
  Coverage   53.01%   53.01%           
=======================================
  Files        1101     1101           
  Lines       59096    59096           
  Branches     4813     4813           
=======================================
  Hits        31329    31329           
  Misses      27049    27049           
  Partials      718      718
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from a2a61df
packages 50.15% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@joaquim-verges joaquim-verges merged commit 3683c11 into main Dec 19, 2024
32 checks passed
@joaquim-verges joaquim-verges deleted the docs_Simplify_React_Native_sidebar_navigation branch December 19, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakubkrehel jakubkrehel Awaiting requested review from jakubkrehel

Assignees

@joaquim-verges joaquim-verges

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joaquim-verges